Skip to content

Rename extra#576

Merged
guillaumeeb merged 5 commits into
dask:mainfrom
jolange:rename_extra
Aug 12, 2022
Merged

Rename extra#576
guillaumeeb merged 5 commits into
dask:mainfrom
jolange:rename_extra

Conversation

@jolange

@jolange jolange commented Aug 12, 2022

Copy link
Copy Markdown
Contributor

Renamed extra to worker_extra_args and added a FutureWarning for extra.

If worker_extra_args is empty, extra will still be respected (see new tests).

Resolves #323

jacobtomlinson
jacobtomlinson approved these changes Aug 12, 2022
View reviewed changes

@jacobtomlinson jacobtomlinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great many thanks! One small comment but otherwise looks good to me.

Comment thread dask_jobqueue/jobqueue.yaml Outdated
guillaumeeb
guillaumeeb approved these changes Aug 12, 2022
View reviewed changes

@guillaumeeb guillaumeeb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@guillaumeeb guillaumeeb merged commit 96e39da into dask:main Aug 12, 2022
@jolange jolange mentioned this pull request Aug 25, 2022
Open
@nsmith- nsmith- mentioned this pull request Sep 7, 2022
Merged
jolange added a commit to jolange/dask-jobqueue that referenced this pull request Oct 3, 2022
@jolange
re-assigning worker_extra_args instead of altering it with +=
19c78e8 
Because `worker_extra_args` is assigned to a config value. With `+=`
the config value is changed every time, so the args will be appended
again for each job resulting in dask#589.

It's a regression from dask#576.

Fixes dask#589
@jolange jolange mentioned this pull request Oct 3, 2022
Merged
guillaumeeb pushed a commit that referenced this pull request Oct 3, 2022
@jolange
re-assigning worker_extra_args instead of altering it with += (#591)
a6be519 
Because `worker_extra_args` is assigned to a config value. With `+=`
the config value is changed every time, so the args will be appended
again for each job resulting in #589.

It's a regression from #576.

Fixes #589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobtomlinson jacobtomlinson jacobtomlinson approved these changes
@guillaumeeb guillaumeeb guillaumeeb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

job_extra, extra and env_extra naming could be improved

3 participants

@jolange @jacobtomlinson @guillaumeeb